Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Boolean control change for UI Fix toggle button #14408

Merged
merged 2 commits into from
May 7, 2021

Conversation

cjmcintyre
Copy link
Contributor

@cjmcintyre cjmcintyre commented Mar 31, 2021

Issue: UI: Fix toggle button for custom theming #13924

Boolean control change for UI Fix toggle button for custom themeing

Apologies in advance if anything here is out of your norm.. First time contributing to an O/S project + first time using storybook... 😟

What I did

Reproduced by: git cloning, added custom theming .storybook/YourTheme.js (complex example) and a control button as per examples on playbook website.

When adding the custom theme it seems Control takes the property form barBg as indicated beforehand, the propose change will make it take from appBg instead.

Example of my custom theme

    // UI
    appBg: 'white',
    appContentBg: 'silver',
    appBorderColor: 'grey',
    appBorderRadius: 4,  

    // Toolbar default and active colors
    barTextColor: 'silver',
    barSelectedColor: 'black',
    barBg: 'black',
  

How to test

Tested by: Reproducing above and then applying fix to Boolean.tsx and building locally with yarn build-storybook to test (Sorry no automation this time...)

playbook

  • Is this testable with Jest or Chromatic screenshots?
    Not sure, sorry.
  • Does this need a new example in the kitchen sink apps?
    Not that I'm aware of.
  • Does this need an update to the documentation?
    Not that I'm aware of.

If your answer is yes to any of these, please make sure to include it in your PR.

Boolean control change for UI Fix toggle button for custom themeing
@cjmcintyre cjmcintyre marked this pull request as ready for review March 31, 2021 07:05
@shilman shilman changed the title Boolean control change for UI Fix toggle button UI: Boolean control change for UI Fix toggle button May 6, 2021
@nx-cloud
Copy link

nx-cloud bot commented May 6, 2021

Nx Cloud Report

CI ran the following commands for commit 70d6826. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

Copy link
Member

@ndelangen ndelangen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies in advance if anything here is out of your norm.. First time contributing to an O/S project + first time using storybook... 😟

It's very important to us that new contributors feel welcome, and are encouraged.

Thank you very much for fixing this bug @cjmcintyre !

This looks great to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants