UI: Boolean control change for UI Fix toggle button #14408
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: UI: Fix toggle button for custom theming #13924
Boolean control change for UI Fix toggle button for custom themeing
Apologies in advance if anything here is out of your norm.. First time contributing to an O/S project + first time using storybook... 😟
What I did
Reproduced by: git cloning, added custom theming .storybook/YourTheme.js (complex example) and a control button as per examples on playbook website.
When adding the custom theme it seems Control takes the property form barBg as indicated beforehand, the propose change will make it take from appBg instead.
Example of my custom theme
How to test
Tested by: Reproducing above and then applying fix to Boolean.tsx and building locally with yarn build-storybook to test (Sorry no automation this time...)
Not sure, sorry.
Not that I'm aware of.
Not that I'm aware of.
If your answer is yes to any of these, please make sure to include it in your PR.