Upgrade dotenv-webpack to v6
#14492
Merged
Upgrade dotenv-webpack to v6
#14492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
approved these changes
Apr 7, 2021
|
🤞🏼 Thank you!! |
This was referenced Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #14403
What I did
This PR bumps
dotenv-webpackto v6 in places that were still using v1.8, resolving #14403.How to test
All tests pass.
I also reviewed
dotenv-webpack's changelog to ensure there weren't side effects of this upgrade. Some parts of Storybook are already using v6 and there do not appear to be any breaking changes from this upgrade, so I feel pretty confident it will work fine.