CI: Remove Travis, fix TeamCity, rework E2E on CircleCI #14522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaetanmaisse
force-pushed
the
tech/clean-ci
branch
from
6578b97 to
75151e3
Compare
|
Hey @Hypnosphi, I'm trying to fix the TeamCity builds but I don't know much about it, is there a simple way to run the builds with the updates I made in this branch? Because if I understand correctly it's always using the I would be glad to discuss that on discord, feels free to ping me (same username as here ;)) |
|
I changed the configuration to use settings from PR branch by default and re-started the build: https://storybook.beta.teamcity.com/buildConfiguration/Hosted_Root_TestWorkflow/126136 |
|
Thanks! I should be able to fix the failing jobs ;) and will let you know if I need some extra support. |
gaetanmaisse
force-pushed
the
tech/clean-ci
branch
3 times, most recently
from
94a8e7c to
4a987f2
Compare
gaetanmaisse
force-pushed
the
tech/clean-ci
branch
2 times, most recently
from
2896a1e to
257444f
Compare
Hypnosphi
approved these changes
Apr 13, 2021
gaetanmaisse
force-pushed
the
tech/clean-ci
branch
from
257444f to
034bb6c
Compare
New layout: - `e2e-tests-core` for "officially" supported frameworks : Vue + Angular (+ React + Web Components in e2e-tests-pnp) - `e2e-tests-extended` for other frameworks: Preact, Svelte, Riot, Rax etc - `e2e-tests-pnp` for some frameworks/setups compatible with PnP: React + WC
Previously Cypress was installed manually to be sure to run with Node 10. We can now use the docker images provided by Cypress team (at least for the 6.8) because they are based on Node 12, the one we are using across the CI.
Also, fix the behavior and trigger a new run each time a label is set/unset on a PR.
gaetanmaisse
force-pushed
the
tech/clean-ci
branch
from
021fc11 to
bfc1912
Compare
gaetanmaisse
requested review from
danielduan,
igor-dv and
ndelangen
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
e2e-tests-corefor "officially" supported frameworks : Vue + Angular (+ React + Web Components in e2e-tests-pnp)e2e-tests-extendedfor other frameworks: Preact, Svelte, Riot, Rax etce2e-tests-pnpfor some frameworks/setups compatible with PnP: React + WCHow to test