Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vue: Fix VueLoaderPlugin import to support vue-loader@16.x #14624

Merged
merged 1 commit into from
Jan 4, 2022
Merged

Vue: Fix VueLoaderPlugin import to support vue-loader@16.x #14624

merged 1 commit into from
Jan 4, 2022

Conversation

Jogiter
Copy link
Contributor

@Jogiter Jogiter commented Apr 16, 2021

fix #14623

@shilman shilman added vue maintenance User-facing maintenance tasks labels Apr 16, 2021
shilman
shilman approved these changes Apr 16, 2021
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Jogiter thanks for this! Is the change backwards compatible with older versions of vue-loader?

@Jogiter
Copy link
Contributor Author

Jogiter commented Apr 16, 2021

Hey @Jogiter thanks for this! Is the change backwards compatible with older versions of vue-loader?

@storybook/vue@6.3.0-alpha.8 dependent on "vue-loader"@"^15.9.6".
i have validate the change will backwards compatible with vue-loader since V15

@shilman shilman changed the title feat: fix VueLoaderPlugin import to support vue-loader@16.x Vue: Fix VueLoaderPlugin import to support vue-loader@16.x Jan 4, 2022
@shilman shilman merged commit 1adaa4b into storybookjs:next Jan 4, 2022
This was referenced Jan 4, 2022
Closed
Closed
This was referenced Jan 22, 2022
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@kazupon kazupon Awaiting requested review from kazupon

@thomasbertet thomasbertet Awaiting requested review from thomasbertet

Assignees

@shilman shilman

Labels
maintenance User-facing maintenance tasks vue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@storybook/vue won`t work when using vue-loader@16.x
2 participants
@Jogiter @shilman