-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Fix tab display when there is only one tab #14790
UI: Fix tab display when there is only one tab #14790
Conversation
Nx Cloud ReportCI ran the following commands for commit 2789a64. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
c4ed885
to
6f7e302
Compare
6f7e302
to
c735c90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- great stuff @Tomastomaslol 🥇. @ndelangen ?
I'm fine with this. Though I do wonder what's the use-case of having a tab interface, if there's only 1 option? |
I guess it could valuable to know the name of the tab you are on currently. There is also this "soft 404" scenario: Scenario previewTabs: {
canvas: { hidden: true },
}, Request: You can still request the canvas view when the tab hidden in the configuration. To be able to navigate to an active tab you would need the tabs menu. Is being able to visit a hidden tab by requesting the URL a bug? I have seen some issues logged for it:
I'm not sure that hidden should equal inaccessible and I can see some value in separating the concepts. |
Another contribution merged @Tomastomaslol 💪 |
Issue: #14598
What I did
isToolshown
to setisToolshown
How to test
Scenarios
Canvas disabled, docs panels enbaled
Canvas enbaled, docs panels disabled
Canvas enbaled, docs panels enbaled
Canvas disabled, docs panels disabled