Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-actions: Display DOM Event/CustomEvent data #14879

Merged
merged 1 commit into from
May 11, 2021

Conversation

gaetanmaisse
Copy link
Member

Issue: #8544

What I did

A workaround has been found in telejson to keep interesting data when serializing DOM Event/CustomEvent. For details, see storybookjs/telejson#63.

So I just bumped telejson everywhere in the monorepo to include the "fix".

How to test

  • Run lit or web_components kitchen sink, go to Actions stories and check that actions displayed in Action panel contain more than just isTrusted attribute.

Before
image

After
image

A workaround has been found in `telejson` to keep interesting data when serializing DOM Event/CustomEvent. For details, see storybookjs/telejson#63
@nx-cloud
Copy link

nx-cloud bot commented May 10, 2021

Nx Cloud Report

CI ran the following commands for commit 63ea058. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@nx-cloud
Copy link

nx-cloud bot commented May 10, 2021

Nx Cloud Report

We didn't find any information for the current pull request with the commit 63ea058.
Please make sure you set the \ NX_BRANCH\ environment variable in your CI pipeline .

Check the Getting started section to configure the app.


Sent with 💌 from NxCloud.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@gaetanmaisse gaetanmaisse marked this pull request as ready for review May 10, 2021 18:18
@shilman shilman changed the title Actions: Display DOM Event/CustomEvent data Addon-actions: Display DOM Event/CustomEvent data May 11, 2021
@shilman shilman merged commit 8aa65a3 into next May 11, 2021
@shilman shilman deleted the addon-actions-display-event-data branch May 11, 2021 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants