Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to consolidate hierarchy UI (+ some other fixes) #1488

Merged
merged 5 commits into from
Jul 20, 2017

Conversation

igor-dv
Copy link
Member

@igor-dv igor-dv commented Jul 19, 2017

Issue: #151

What I did

Here is the current state of the UI

  1. Toggle icon changed to chevron
  2. Other icons are removed ( 😢 ). According to @shilman it looks cleaner.

image

Other changes in the same branch:

  1. '/' is set as default to the hierarchySeparator
  2. storybook-react-treebeard changed back to react-treebeard

How to test

TBD

@ndelangen
Copy link
Member

In the future we will allow addons to customize the treeview/navigation component, I'm OK with this look, it's something we can iterate on after release IMHO.

@codecov
Copy link

codecov bot commented Jul 19, 2017

Codecov Report

Merging #1488 into release/3.2 will increase coverage by 0.16%.
The diff coverage is 30%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/3.2    #1488      +/-   ##
===============================================
+ Coverage        20.27%   20.44%   +0.16%     
===============================================
  Files              240      236       -4     
  Lines             5188     5146      -42     
  Branches           637      622      -15     
===============================================
  Hits              1052     1052              
+ Misses            3641     3624      -17     
+ Partials           495      470      -25
Impacted Files Coverage Δ
...les/ui/components/left_panel/stories_tree/index.js 100% <ø> (ø) ⬆️
lib/ui/src/modules/api/index.js 0% <ø> (ø) ⬆️
...i/components/left_panel/stories_tree/tree_style.js 25% <ø> (ø) ⬆️
lib/ui/example/client/provider.js 0% <ø> (ø) ⬆️
...ponents/left_panel/stories_tree/tree_decorators.js 31.94% <30%> (-0.92%) ⬇️
app/react-native/src/preview/story_kind.js 0% <0%> (ø) ⬆️
addons/events/src/components/Event.js 0% <0%> (ø) ⬆️
...react-native/src/manager/components/PreviewHelp.js 0% <0%> (ø) ⬆️
...mponents/left_panel/stories_tree/tree_node_type.js 0% <0%> (ø) ⬆️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c717ae...64c053f. Read the comment docs.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a work of art. Thank you @igor-dv !!! 🎉

@tmeasday
Copy link
Member

Looking great!

@igor-dv igor-dv merged commit 874a780 into release/3.2 Jul 20, 2017
@shilman shilman added cleanup Minor cleanup style change that won't show up in release changelog and removed feature request labels Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Minor cleanup style change that won't show up in release changelog ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants