Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show first story on OnDeviceUI startup #1510

Merged
merged 4 commits into from
Jul 23, 2017
Merged

Conversation

shilman
Copy link
Member

@shilman shilman commented Jul 22, 2017

Issue: #1492

What I did

  • Fix startup message
  • Fix required URL prop-type error (I think this is not really a fix @matt-oakes @ajwhite ?)
  • Automatically jump to first story when OnDeviceUI starts

How to test

yarn && yarn bootstrap && yarn bootstrap:react-native-vanilla
cd examples/react-native-vanilla
yarn storybook
open http://localhost:7007
./node_modules/.bin/react-native run-ios

You should see the first story Welcome > to Storybook selected in the on-device UI.

@matt-oakes I’m not sure why I need to do this but I get a “URL
required” prop-types error unless I force `resetStorybook` in
`react-native-vanilla` example
@shilman shilman merged commit dfaaa09 into release/3.2 Jul 23, 2017
@Hypnosphi Hypnosphi deleted the 1492-on-device-startup branch August 17, 2017 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants