UI: Fix padded layout in Firefox after resetting scale #15128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scale actions on firefox
Nx Cloud ReportCI ran the following commands for commit 7a5d4d9. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
|
@ghengeveld can you look at this when you have time? Seems vaguely related to the layout parameter work you did before and I want to be careful that we don't introduce any unintentional breaking changes. |
ghengeveld
approved these changes
Jun 16, 2021
There was a problem hiding this comment.
Tested and verified. LGTM. Nice work @BartJanvanAssen and good to see you took my suggestion to heart ❤️
ghengeveld
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #15041
What I did
I've started the angular project (example/angular-cli), noticed the bug in firefox (not in chrome). Applied the suggested fix (add box-sizing property).
How to test
Regards