Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed build-storybook for vue #1564

Merged
merged 1 commit into from
Aug 1, 2017
Merged

Fixed build-storybook for vue #1564

merged 1 commit into from
Aug 1, 2017

Conversation

shilman
Copy link
Member

@shilman shilman commented Aug 1, 2017

Issue: N/A build-storybook was failing on vue projects (thanks @timhaines)

What I did

Add the vue loader to the webpack config used by build-storybook

How to test

yarn bootstrap
cd examples/vue-kitchen-sink
yarn build-storybook

@shilman shilman changed the title Add vue-loader to vue production webpack (fixes build-storybook) Fixed build-storybook for vue Aug 1, 2017
@shilman shilman added the bug label Aug 1, 2017
timhaines
timhaines approved these changes Aug 1, 2017
View reviewed changes
Copy link

@timhaines timhaines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I've tried this locally, and it fixed a broken build of a vue storybook. 🚀

@shilman shilman merged commit a12ccb3 into master Aug 1, 2017
@shilman shilman deleted the fix-vue-build-storybook branch August 1, 2017 02:52
This was referenced Jan 12, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhaines timhaines timhaines approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shilman @timhaines