Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 refactor(examples): Remove unnecesary code #1574

Merged
merged 3 commits into from
Aug 3, 2017

Conversation

kazupon
Copy link
Member

@kazupon kazupon commented Aug 2, 2017

Issue:

What I did

Refactor vue example code (.vue)

How to test

Please review.

@kazupon kazupon added the vue label Aug 2, 2017
@ndelangen ndelangen changed the title 🔥 refactor(examples): Remove unecesary code 🔥 refactor(examples): Remove unnecesary code Aug 2, 2017
Copy link
Member

@ndelangen ndelangen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you tested this locally, go ahead and merge!

@codecov
Copy link

codecov bot commented Aug 2, 2017

Codecov Report

Merging #1574 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1574      +/-   ##
==========================================
+ Coverage   20.41%   20.43%   +0.01%     
==========================================
  Files         241      241              
  Lines        5255     5252       -3     
  Branches      664      660       -4     
==========================================
  Hits         1073     1073              
- Misses       3660     3676      +16     
+ Partials      522      503      -19
Impacted Files Coverage Δ
lib/ui/src/modules/ui/containers/left_panel.js 25% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-start.js 0% <0%> (ø) ⬆️
addons/info/src/components/Node.js 38.88% <0%> (ø) ⬆️
addons/info/src/components/markdown/htags.js 30% <0%> (ø) ⬆️
...rc/modules/ui/components/left_panel/text_filter.js 33.33% <0%> (ø) ⬆️
addons/info/src/components/Props.js 37.2% <0%> (ø) ⬆️
addons/knobs/src/KnobManager.js 35.41% <0%> (ø) ⬆️
addons/storyshots/src/storybook-channel-mock.js 0% <0%> (ø) ⬆️
app/react/src/server/index.html.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Number.js 8.06% <0%> (ø) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1986eb...ecfceac. Read the comment docs.

@kazupon
Copy link
Member Author

kazupon commented Aug 3, 2017

OK! 💪

@kazupon kazupon merged commit bfc9c85 into storybookjs:master Aug 3, 2017
@kazupon kazupon deleted the tweak/vue-example branch August 3, 2017 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants