Change ClientApi to be a facade in front of the store
#16006
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nx Cloud ReportWe didn't find any information for the current pull request with the commit 6e6f0ef. Check the Nx Cloud Github Integration documentation for more information. Sent with 💌 from NxCloud. |
shilman
reviewed
Sep 10, 2021
| const clientApi = new ClientApi(); | ||
| let data; | ||
|
|
||
| clientApi.setAddon({ |
There was a problem hiding this comment.
let's deprecate and remove in 7.0?
There was a problem hiding this comment.
Good idea, want to open a ticket for it?
Yes we do. I think @bebraw has prototyped it over in the skeleton. |
Yup, I have a basic implementation in place there at tmeasday/storybook-skeleton#28 . |
|
Merged as part of #15871 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #15871
Telescoping on #16005
What I did
Change the behaviour of the v6 APIs/entrypoints to use the on-demand store in a pre-loaded (i.e. not on-demand) way.
Change the
@storybook/client-apiAPI exports (which are re-exported by the various app layers) to be a "facade" in front of the story store. What this means is:addDecorators()& friends are collected on the Client API, and passed to aWebPreviewas agetProjectAnnotationsfunction.storiesOf()are are collected, and massaged into a "CSF import" that is then supplied as a (synchronous)importFn.add()are similarly added to the CSF imports, and also indexed into to be passed as a (synchronous)fetchStoryIndexfunction. Note this function implements story sorting in the preview[1]Similarly, if a
Loadableis passed to theconfigure()function (like arequire.context), its exports (CSF exports) are collected by theClientApiin a similar way to the above.When the
start()function (called by all e.g.@storybook/reactentry points) is called it creates the above and a webpreview, which itinitialize()s synchronously -- which means all stories are loaded right away.[1] In the v7 store the story sorting of the index happens in node.