Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add app layer presets #16012

Conversation

tmeasday
Copy link
Member

Part of #15871

Telescoping on #16011

What I did

Add presets to each app layer, as this is the way the v7 store gets the framework parameter, the renderToDOM function and the (optional) render function.

@tmeasday tmeasday mentioned this pull request Sep 11, 2021
14 tasks
@nx-cloud
Copy link

nx-cloud bot commented Sep 11, 2021

Nx Cloud Report

We didn't find any information for the current pull request with the commit a75061c.
You might need to set the 'NX_BRANCH' environment variable in your CI pipeline.

Check the Nx Cloud Github Integration documentation for more information.


Sent with 💌 from NxCloud.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2021

Fails
🚫

PR is not labeled with one of: ["cleanup","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies","other"]

Generated by 🚫 dangerJS against a75061c

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 💯

@shilman
Copy link
Member

shilman commented Sep 14, 2021

Merged as part of #15871

@shilman shilman closed this Sep 14, 2021
@stof stof deleted the on-demand-store-8-app-layer-presets branch May 25, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants