Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add shortcut for running yarn storybook in cra-kitchen-sink #1605

Merged
merged 3 commits into from
Aug 6, 2017

Conversation

Hypnosphi
Copy link
Member

@Hypnosphi Hypnosphi commented Aug 6, 2017

Before

cd examples/cra-kitchen-sink && yarn storybook

After

yarn start

@usulpro usulpro added react feature request maintenance User-facing maintenance tasks labels Aug 6, 2017
@usulpro
Copy link
Member

usulpro commented Aug 6, 2017

Great! It's a sort of script that I really wanted to have 👍

The only inconvenience for me that my terminal doesn't support auto filling yarn commands by [Tab]. And I will need to type it manually (while it works for paths). So, in this case, I'd prefer something shorter e.g. yarn start :)

@codecov
Copy link

codecov bot commented Aug 6, 2017

Codecov Report

Merging #1605 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1605   +/-   ##
=======================================
  Coverage   21.35%   21.35%           
=======================================
  Files         244      244           
  Lines        5376     5376           
  Branches      655      654    -1     
=======================================
  Hits         1148     1148           
- Misses       3724     3747   +23     
+ Partials      504      481   -23
Impacted Files Coverage Δ
lib/ui/src/modules/ui/components/menu_item.js 19.14% <0%> (ø) ⬆️
addons/knobs/src/react/WrapStory.js 12% <0%> (ø) ⬆️
lib/ui/src/modules/ui/libs/hierarchy.js 45.45% <0%> (ø) ⬆️
addons/info/src/components/Props.js 37.2% <0%> (ø) ⬆️
addons/knobs/src/components/types/Color.js 8% <0%> (ø) ⬆️
addons/knobs/src/components/PropForm.js 8.51% <0%> (ø) ⬆️
lib/ui/src/modules/shortcuts/actions/shortcuts.js 6.25% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/down_panel.js 23.52% <0%> (ø) ⬆️
addons/knobs/src/KnobManager.js 35.41% <0%> (ø) ⬆️
app/react/src/client/preview/element_check.js 41.17% <0%> (ø) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e783776...2d93244. Read the comment docs.

@Hypnosphi
Copy link
Member Author

Ok, renamed that

@usulpro
Copy link
Member

usulpro commented Aug 6, 2017

Looks good to me!
(could you change script name in your first comment?)

@Hypnosphi
Copy link
Member Author

Did that as well

@ndelangen
Copy link
Member

Good first step, to making running the example(s) easier, thanks. Will be improving on this at a later stage! (we do have more examples 👍 )

@ndelangen ndelangen merged commit 89b6b41 into master Aug 6, 2017
@ndelangen ndelangen deleted the shortcut-cra branch August 6, 2017 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks react
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants