CSF: Add CSF2 play function example #16121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nx Cloud ReportCI ran the following commands for commit 723f645. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
tmeasday
reviewed
Sep 22, 2021
Comment on lines
+220
to
+225
|
|
||
| /** | ||
| * Define a custom render function for the story(ies). If not passed, a default render function by the framework will be used. | ||
| */ | ||
| render?: (args: Args, context: StoryContext) => StoryFnReturnType; | ||
|
|
There was a problem hiding this comment.
Did you intentionally check in no changes to the CSF2 types here?
There was a problem hiding this comment.
Yes, it's already in the type. I just added missing spaces.
shilman
added
maintenance
shilman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #16120
What I did
playfunction in CSF2self-merging @jonniebigodes @kylegach
How to test
Uncomment the code in
react-ts. Need to figure out next steps for how we want to document this, so leaving it very minimal until we've decided.