Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable flow types in stories #1621

Closed
wants to merge 2 commits into from
Closed

Enable flow types in stories #1621

wants to merge 2 commits into from

Conversation

danielduan
Copy link
Member

Issue:

Flow typed components cannot be added to Storybooks easily without defining a new .babelrc. We only need to include a babel plugin to make it work so I think it's worth the extra package.

What I did

Added babel-preset-flow to the default .babelrc and

How to test

Example app has a FlowButton

@jribeiro
Copy link
Contributor

jribeiro commented Aug 8, 2017

babel-preset-flow is already included by babel-preset-react as can be seen on the package
https://www.npmjs.com/package/babel-preset-react

There's no need to add the additional dependency. Actually the original merge request for this feature seems to work just fine.

See:
#1623
#1562
#1505

@danielduan danielduan closed this Aug 8, 2017
@danielduan danielduan deleted the dd/flow-support branch August 18, 2017 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants