Core: Unified story specifiers #16220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Nx Cloud ReportCI ran the following commands for commit 87008af. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
tmeasday
commented
Oct 3, 2021
Comment on lines
+188
to
+191
| STORIES: stories.map((specifier) => ({ | ||
| ...specifier, | ||
| importPathMatcher: specifier.importPathMatcher.source, | ||
| })), |
There was a problem hiding this comment.
I had to add this little hack as the regexps weren't being serialized properly
tmeasday
force-pushed
the
16047-refactor-specifiers
branch
from
02ad3c6 to
e0b29fd
Compare
tmeasday
added a commit
to storybookjs/addon-ie11
that referenced
this pull request
Oct 5, 2021
… it. This mainly to stop tests from hanging
shilman
requested changes
Oct 7, 2021
| // Watchpack passes paths either with no leading './' - e.g. `src/Foo.stories.js`, | ||
| // or with a leading `../` (etc), e.g. `../src/Foo.stories.js`. | ||
| // We want to deal in importPaths relative to the working dir, or absolute paths. | ||
| const importPath = watchpackPath.startsWith('.') ? watchpackPath : `./${watchpackPath}`; |
There was a problem hiding this comment.
is this the only place we do this now? is this unified from before?
There was a problem hiding this comment.
Yes, any time we talk about paths we either use an importPath (JS-style relative to workingDir) [for things that end up inside the bundle] or an absolutePath [for things that don't]. The two things that liked to use "html-style" relative paths were:
watchpack, which is why we do this heremicromatch, which is why we have to futz with the generated regexp a little bit.
tmeasday
commented
Oct 7, 2021
shilman
changed the title
shilman
added
maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Specifiers were a bit of an unspecified (ha) mess.
Telescoping on #16160
What I did
What I still need to do