Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: Make types generic for angular's built-in decorators #16266

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Oct 7, 2021

Issue: #16212

What I did

Made the exported angular decorators more generic.

We aren't sure if there are other decorators floating around that are typed like this. If there are we might need to do something more drastic and weaken the Meta/Story types for 6.3 so decorators do not contain args type information.

@nx-cloud
Copy link

nx-cloud bot commented Oct 7, 2021

Nx Cloud Report

CI ran the following commands for commit 7369895. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@shilman shilman changed the title Make the types generic for the angular decorators Angular: Make types generic for angular's built-in decorators Oct 7, 2021
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me! let's keep an eye out for related problems 👀

@shilman shilman added this to the 6.4 PRs milestone Oct 7, 2021
@shilman shilman merged commit fd399ac into next Oct 7, 2021
@shilman shilman deleted the 16212-fix-angular-decorator-types branch October 7, 2021 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants