Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update template config for webpack react project #1628

Merged
merged 3 commits into from
Aug 9, 2017
Merged

Update template config for webpack react project #1628

merged 3 commits into from
Aug 9, 2017

Conversation

pd4d10
Copy link
Contributor

@pd4d10 pd4d10 commented Aug 9, 2017

Issue: webpack 2+ use rules instead of loaders

What I did

Update template config for webpack react project

How to test

@codecov
Copy link

codecov bot commented Aug 9, 2017

Codecov Report

Merging #1628 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1628   +/-   ##
=======================================
  Coverage   21.34%   21.34%           
=======================================
  Files         244      244           
  Lines        5378     5378           
  Branches      661      667    +6     
=======================================
  Hits         1148     1148           
- Misses       3719     3732   +13     
+ Partials      511      498   -13
Impacted Files Coverage Δ
lib/ui/src/modules/api/actions/api.js 49.42% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/menu_item.js 19.14% <0%> (ø) ⬆️
addons/info/src/components/PropTable.js 22.36% <0%> (ø) ⬆️
addons/knobs/src/components/types/Object.js 5.81% <0%> (ø) ⬆️
app/react-native/src/preview/story_kind.js 0% <0%> (ø) ⬆️
...ponents/left_panel/stories_tree/tree_decorators.js 32.98% <0%> (ø) ⬆️
.../src/manager/containers/CommentsPanel/dataStore.js 34.78% <0%> (ø) ⬆️
addons/knobs/src/components/types/Color.js 8% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-start.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/routes.js 0% <0%> (ø) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9197fb0...81ea071. Read the comment docs.

@Hypnosphi Hypnosphi self-assigned this Aug 9, 2017
@Hypnosphi Hypnosphi self-requested a review August 9, 2017 20:38
@Hypnosphi
Copy link
Member

Note for myself: test that it works when user has webpack 1 in their app

@Hypnosphi
Copy link
Member

Oh, I've missed the fact that it's a template.

@Hypnosphi Hypnosphi merged commit df6b304 into storybookjs:master Aug 9, 2017
@Hypnosphi Hypnosphi added the maintenance User-facing maintenance tasks label Aug 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants