Args: Add ability to specific argType "targets" #16333
Conversation
Nx Cloud ReportCI ran the following commands for commit c7912a8. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
Nx Cloud ReportWe didn't find any information for the current pull request with the commit 8103861. Check the Nx Cloud Github Integration documentation for more information. Sent with 💌 from NxCloud. |
shilman
changed the title
|
Yep! What do you think about the other frameworks? Should I do them too? |
|
@tmeasday yes please! sorry I missed that comment in your PR description 👍 |
|
Ok, done. I haven't added stories for angular or server (or really tested them). |
| if (!Component) { | ||
| throw new Error( | ||
| `Unable to render story ${id} as the component annotation is missing from the default export` | ||
| ); | ||
| } | ||
| return <Component {...args} />; | ||
|
|
||
| const renderedArgs = FEATURES.argTypeTarget ? noTargetArgs(context) : args; |
There was a problem hiding this comment.
WDYT about adding argsByTarget to the context?
There was a problem hiding this comment.
@shilman I reworked this, as discussed.
Now:
- It is a parameter (similar to
passArgsFirst) rather than aFEATURE. This was just more convenient, I am open to turning it back into a feature if you prefer that. - We filter
argsby default if the feature is on, also addingargsByTargetandfullArgsfor convenience.
|
@shilman I made the changes you requested. |
Issue: #16239
What I did
Still todo
How to test
Yes we have both.