Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for React presence when detecting WEBPACK_REACT type #1646

Merged
merged 6 commits into from
Aug 19, 2017

Conversation

Hypnosphi
Copy link
Member

To prevent incorrect detection when a vue project has webpack installed

@Hypnosphi Hypnosphi added the cli label Aug 12, 2017
(packageJson.dependencies && packageJson.dependencies.webpack)) &&
((packageJson.devDependencies && packageJson.devDependencies.react) ||
(packageJson.dependencies && packageJson.dependencies.react))
) {
Copy link
Member Author

@Hypnosphi Hypnosphi Aug 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably extract those checks into a function

@Hypnosphi Hypnosphi added the bug label Aug 13, 2017
@codecov
Copy link

codecov bot commented Aug 18, 2017

Codecov Report

Merging #1646 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1646   +/-   ##
=======================================
  Coverage   20.87%   20.87%           
=======================================
  Files         251      251           
  Lines        5629     5629           
  Branches      675      690   +15     
=======================================
  Hits         1175     1175           
+ Misses       3952     3926   -26     
- Partials      502      528   +26
Impacted Files Coverage Δ
lib/cli/lib/detect.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/PropField.js 10.86% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/layout.js 12.5% <0%> (ø) ⬆️
...es__/update-addon-info/update-addon-info.output.js 0% <0%> (ø) ⬆️
addons/info/src/components/Props.js 37.2% <0%> (ø) ⬆️
lib/ui/src/modules/ui/libs/filters.js 53.33% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-start.js 0% <0%> (ø) ⬆️
...ponents/left_panel/stories_tree/tree_decorators.js 32.29% <0%> (ø) ⬆️
addons/knobs/src/components/types/Number.js 8.06% <0%> (ø) ⬆️
addons/info/src/components/PropTable.js 20.16% <0%> (ø) ⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 666eafe...a7181ac. Read the comment docs.

@ndelangen
Copy link
Member

Merge when ready

@Hypnosphi Hypnosphi merged commit 0d5624c into master Aug 19, 2017
@ndelangen ndelangen deleted the fix-vue-webpack branch August 19, 2017 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants