bug: provide args values from url to control

[pahan35]

Issue: #15278

What I did

I passed values from URL to ArgsTable by emitting storyArgsUpdated with URL args state, which is not populated on the initial render.

How to test

Go to the issue and try to reproduce it with these changes.

If a unit test is necessary for this fix, let me know how to write it.

• Is this testable with Jest or Chromatic screenshots?
• Does this need a new example in the kitchen sink apps?
• Does this need an update to the documentation?

[nx-cloud]

Nx Cloud Report

CI ran the following commands for commit 4fb913d. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status	Command
	nx run-many --target=prepare --all --parallel --max-parallel=15

---

Sent with 💌 from NxCloud.

[tmeasday]

Hey @pahan35 thanks for this!

Actually this is very similar to a PR I just implemented #16488, which covers off emitting the event on a different code path (HMR).

I think it would make sense to emit from the same place I did

storybook/lib/preview-web/src/PreviewWeb.tsx

Lines 371 to 373 in db17405

	if (implementationChanged) {
	this.channel.emit(Events.STORY_ARGS_UPDATED, { storyId, args });
	}

- except also in the case of persisted args.

I would also love to see a test for this. Thanks!

[pahan35]

Hey @pahan35 thanks for this!

Actually this is very similar to a PR I just implemented #16488, which covers off emitting the event on a different code path (HMR).

I think it would make sense to emit from the same place I did

storybook/lib/preview-web/src/PreviewWeb.tsx

Lines 371 to 373 in db17405

	if (implementationChanged) {
	this.channel.emit(Events.STORY_ARGS_UPDATED, { storyId, args });
	}

• except also in the case of persisted args.
  I would also love to see a test for this. Thanks!

Great changes! Thanks for working on it. I'll close this one.

[tmeasday]

Hey @pahan35 - I wasn't saying that you should close this, my changes won't help with the case you are fixing here (when we set args on load via persistedArgs). Would you like to make a new PR that builds off mine?