Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Storybook was hard crashing if used alongside React 16 beta release.
What I did
I followed error stack traces and found out that the isue was caused by
react-modal
package that used long goneReact.DOM.*
helpers.I swapped it out with the latest version, and it worked! Turns out
react-modal
had a major release since the dependent-upon1.7.7
, but according to changelog, it went without breaking changes.I never used seach UI (which uses
react-modal
) before, but it seems to be working fine.How to test
npm install --save react@next react-dom@next