Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change React.PropTypes to prop-types #1674

Merged
merged 3 commits into from
Aug 17, 2017
Merged

change React.PropTypes to prop-types #1674

merged 3 commits into from
Aug 17, 2017

Conversation

danielduan
Copy link
Member

@danielduan danielduan commented Aug 17, 2017

Issue:
#1673 React.PropTypes is deprecated and removed completely in React@16-beta

What I did

ran jscodeshift and changed them

How to test

run the example app with react-native@16

@danielduan danielduan added dependencies maintenance User-facing maintenance tasks and removed react-native labels Aug 17, 2017
@codecov
Copy link

codecov bot commented Aug 17, 2017

Codecov Report

Merging #1674 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1674      +/-   ##
==========================================
- Coverage   20.57%   20.56%   -0.02%     
==========================================
  Files         247      247              
  Lines        5554     5557       +3     
  Branches      664      664              
==========================================
  Hits         1143     1143              
- Misses       3898     3901       +3     
  Partials      513      513
Impacted Files Coverage Δ
...-native/src/preview/components/OnDeviceUI/index.js 0% <0%> (ø) ⬆️
...tive/src/preview/components/StoryListView/index.js 0% <0%> (ø) ⬆️
...t-native/src/preview/components/StoryView/index.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/shortcuts/actions/shortcuts.js 6.25% <0%> (ø) ⬆️
...ponents/left_panel/stories_tree/tree_decorators.js 32% <0%> (ø) ⬆️
lib/ui/src/libs/key_events.js 23.25% <0%> (ø) ⬆️
addons/info/src/components/markdown/htags.js 30% <0%> (ø) ⬆️
addons/info/src/components/Props.js 37.2% <0%> (ø) ⬆️
addons/info/src/components/PropTable.js 22.36% <0%> (ø) ⬆️
addons/knobs/src/components/types/Color.js 8% <0%> (ø) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d773b05...6d91176. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants