Addon-docs: Fix babel-loader resolution based on builder #16752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e the proper version of babel-loader
☁️ Nx Cloud ReportCI ran the following commands for commit 64cdf45. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
ndelangen
changed the title
shilman
requested changes
Dec 6, 2021
| const { builder = 'webpack4' } = await options.presets.apply('core', {}); | ||
|
|
||
| const resolvedBabelLoader = require.resolve('babel-loader', { | ||
| paths: [require.resolve(`@storybook/builder-${builder}`)], // FIXME!!! |
There was a problem hiding this comment.
What if the builder is storybook-builder-vite? Also what about the FIXME?
There was a problem hiding this comment.
fixme can be removed, it's fixed.
I didn't think of the storybook-builder-vite.
shilman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #15336
What I did
resolve the
corefield via preset.applyread used builder so we resolve the proper version of babel-loader
How to test