Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knobs: allow arrays in object knob proptypes #1701

Merged
merged 10 commits into from
Sep 1, 2017
Merged

Conversation

Hypnosphi
Copy link
Member

Issue: #810

This removes false positive warning when the value of object knob is an array

@codecov
Copy link

codecov bot commented Aug 21, 2017

Codecov Report

Merging #1701 into release/3.3 will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/3.3    #1701   +/-   ##
============================================
  Coverage        23.13%   23.13%           
============================================
  Files              253      253           
  Lines             5745     5745           
  Branches           686      680    -6     
============================================
  Hits              1329     1329           
+ Misses            3932     3931    -1     
- Partials           484      485    +1
Impacted Files Coverage Δ
addons/knobs/src/components/types/Object.js 5.81% <0%> (ø) ⬆️
lib/ui/src/modules/ui/libs/hierarchy.js 50.74% <0%> (ø) ⬆️
lib/codemod/src/transforms/update-addon-info.js 51.16% <0%> (ø) ⬆️
addons/events/src/components/Event.js 0% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/layout/dimensions.js 15.62% <0%> (ø) ⬆️
addons/info/src/components/PropTable.js 21% <0%> (ø) ⬆️
...react-native/src/manager/components/PreviewHelp.js 0% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-build.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/PropField.js 10.86% <0%> (ø) ⬆️
...ents/stories_panel/stories_tree/tree_decorators.js 34.37% <0%> (ø) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e57332...e2d1e6d. Read the comment docs.

@Hypnosphi Hypnosphi changed the base branch from master to release/3.3 August 30, 2017 12:11
@Hypnosphi Hypnosphi requested a review from a team August 31, 2017 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: knobs maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants