Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React: Remove react-dev-utils #17022

Merged
merged 3 commits into from
Jan 3, 2022
Merged

Conversation

Taillook
Copy link
Contributor

@Taillook Taillook commented Dec 15, 2021

Issue: #16093 #17017

What I did

  • don't use WatchMissingNodeModulesPlugin
  • yarn test -u

checked local yarn build, yarn test and cd examples/cra-ts-essentials && yarn storybook

@nx-cloud
Copy link

nx-cloud bot commented Dec 15, 2021

☁️ Nx Cloud Report

CI ran the following commands for commit 62ecebb. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@Taillook
Copy link
Contributor Author

Taillook commented Dec 16, 2021

🧮 E2E Results
cra: KO
sfcVue: OK

😵‍💫
How can solve this error...

@Taillook
Copy link
Contributor Author

I thought is better wait for green of CI of next branch.

@shilman shilman changed the title remove react-dev-utils React: Remove react-dev-utils Jan 3, 2022
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @Taillook and thanks for your patience too! 🙏 Merging

@Scotchester
Copy link

Any possibility of getting this fix backported to the 6.4.x series? We've got multiple repos yelling about the critical-severity immer vulnerability that this is the ultimate fix for, and it looks like 6.5.0 is still a ways off.

@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jan 14, 2022
@shilman
Copy link
Member

shilman commented Jan 14, 2022

@Scotchester @vluoto Can you verify that 6.5 fixes the issue for you? Once I have a few confirmations, I can patch it back to 6.4.x

@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jan 15, 2022
shilman added a commit that referenced this pull request Jan 15, 2022
@Scotchester
Copy link

Yes, I can confirm that once I updated my project to 6.5 alpha, the GitHub security alert pertaining to immer has been resolved.

@shilman
Copy link
Member

shilman commented Jan 18, 2022

@Scotchester It's been patched back to https://github.com/storybookjs/storybook/releases/tag/v6.4.13

@Scotchester
Copy link

🙌 Thank you so much!

@Taillook Taillook deleted the chore/react-dev-utils branch February 16, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch react
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants