Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the test-cra example app. #1706

Merged
merged 1 commit into from
Aug 22, 2017
Merged

Remove the test-cra example app. #1706

merged 1 commit into from
Aug 22, 2017

Conversation

tmeasday
Copy link
Member

No longer needed, we can now test cra-kitchen-sink

Issue:

test-cra is redundant

What I did

Removed it and all references to it

How to test

Let's just ensure the build still works.

No longer needed, we can now test `cra-kitchen-sink`
@codecov
Copy link

codecov bot commented Aug 22, 2017

Codecov Report

Merging #1706 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1706   +/-   ##
=======================================
  Coverage   21.22%   21.22%           
=======================================
  Files         252      252           
  Lines        5706     5706           
  Branches      690      685    -5     
=======================================
  Hits         1211     1211           
+ Misses       3962     3960    -2     
- Partials      533      535    +2
Impacted Files Coverage Δ
app/react/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/react/src/server/babel_config.js 0% <0%> (-83.88%) ⬇️
app/vue/src/server/utils.js 0% <0%> (-32.15%) ⬇️
addons/knobs/src/components/types/Object.js 5.81% <0%> (ø) ⬆️
addons/knobs/src/components/types/Number.js 8.06% <0%> (ø) ⬆️
addons/info/src/components/Props.js 37.2% <0%> (ø) ⬆️
addons/knobs/src/components/types/Boolean.js 11.62% <0%> (ø) ⬆️
lib/ui/src/libs/key_events.js 23.25% <0%> (ø) ⬆️
...codemod/src/transforms/update-organisation-name.js 40.62% <0%> (ø) ⬆️
addons/info/src/components/markdown/htags.js 30% <0%> (ø) ⬆️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f4d05a...e27a9c0. Read the comment docs.

@ndelangen ndelangen added the cleanup Minor cleanup style change that won't show up in release changelog label Aug 22, 2017
@tmeasday tmeasday merged commit c843886 into master Aug 22, 2017
@ndelangen ndelangen deleted the remove-test-cra branch August 22, 2017 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Minor cleanup style change that won't show up in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants