Replace React PropTypes with prop-types in RN CLI/examples

[shilman]

Issue: CLI was still using react PropTypes which are deprecated

What I did

Upgraded RN to use prop-types package

How to test

yarn bootstrap && yarn build-packs && yarn bootstrap:react-native-vanilla
cd examples/react-native-vanilla
yarn storybook
./node_modules/.bin/react-native run-ios

[tmeasday]

What happens if they haven't installed the prop-types package in their app?

[ndelangen]

They will get an error ?

[tmeasday]

Sure, but are we OK with that? If they are using an old version of React?

Probably it's OK now..

[tmeasday]

Or is it OK because our packages depend on prop-types...? Maybe they won't get an error

[ndelangen]

Our UI depends on it indeed, unless npm decided to be a 🐒 and not install flat, the module should always be there, no error occur.

[tmeasday]

unless npm decided to be a 🐒

Ok, I'll consider us completely safe then.

[Hypnosphi]

What happens if they haven't installed the prop-types package in their app?

Thanks to eslint, we have it as a dependency everywhere it's used, as docs suggest

[Hypnosphi]

Generators don't add it though, and I believe we should fix that (as we did with @storybook/addons-* before in #1652)

[ndelangen]

I agree!