Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon Info: Remove broken prop type sort (keep defined order) #1711

Merged
merged 2 commits into from
Aug 22, 2017
Merged

Addon Info: Remove broken prop type sort (keep defined order) #1711

merged 2 commits into from
Aug 22, 2017

Conversation

mordentware
Copy link
Contributor

@mordentware mordentware commented Aug 22, 2017

Issue: Prop Types sort is fundamentally broken. Following conversation in Discord, resolution was to remove sort (rather than add fixed name-based sort).

What I did

  • Removed the broken sort for prop types in the PropTable component within the Info addon.
  • Prop Types will now display in the order they are defined.

How to test

Put prop types for a component in a given order. They will display in that order.

Is this testable with jest or storyshots?
Yes (not currently tested for; tests for the Info addon are minimal and need fleshing out)

Does this need a new example in the kitchen sink apps?
No

Does this need an update to the documentation?
No

@mordentware
Copy link
Contributor Author

I really don't feel like the failing tests are anything to do with my change. Anyone care to comment on that?

@danielduan
Copy link
Member

looks good, thanks!

@danielduan danielduan merged commit fc1aecb into storybookjs:master Aug 22, 2017
@Hypnosphi
Copy link
Member

@mordentware @danielduan someone of you had to update storyshots (npm test -- -u)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants