Fix storyshots with new babel config #1721
Conversation
|
//cc @ndelangen @shilman It turns out there was one more issue regarding storyshots on the newest releases. |
Codecov Report
@@ Coverage Diff @@
## master #1721 +/- ##
=======================================
Coverage 21.18% 21.18%
=======================================
Files 252 252
Lines 5694 5694
Branches 684 692 +8
=======================================
Hits 1206 1206
+ Misses 3965 3941 -24
- Partials 523 547 +24
Continue to review full report at Codecov.
|
app/react/src/server/config/babel.js
Outdated
| @@ -8,7 +8,7 @@ module.exports = { | |||
| targets: { | |||
| browsers: ['last 2 versions', 'safari >= 7'], | |||
| }, | |||
| modules: false, | |||
| modules: process.env.NODE_ENV === 'test' ? undefined : false, | |||
There was a problem hiding this comment.
not sure if we should do undefined here or commonjs. the default for this is commonjs but I'm worried it might change in future versions and break support.
There was a problem hiding this comment.
I can change it. Anyways, if they change the default it will be a major bump.
Want me to set to commonjs?
There was a problem hiding this comment.
Updated! Also did the same for vue and react-native
Issue: #1720
What I did
Set
modulesto'commonjs'when NODE_ENV === 'test'.How to test
Simply test against the storyshot demos.