Webpack: Fix for process
fallback using require.resolve
#17249
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #16896
@storybook/builder-webpack5
uses theProvidePlugin
to provide a polyfill of theprocess
module but doesn't resolve the absolute path to it nor declare it as a dependency.There are more dependency issues but I'll leave those for another time.
What I did
Use
require.resolve
to get the absolute path toprocess/browser.js
and declareprocess
as a dependency.How to test
The PnP e2e test should catch this but it seems it has other issues at the moment.