Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shelljs dependency version #17602

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Update shelljs dependency version #17602

merged 1 commit into from
Mar 7, 2022

Conversation

dmattia
Copy link
Contributor

@dmattia dmattia commented Mar 1, 2022

Issue: #17312

What I did

Updated the shelljs range to only allow versions that do not have active CVEs.

Of note, storybook itself already had the ^0.8.4 version resolving to 0.8.5 in its lockfile, but the range should still be updated for those who depend on libraries like @storybook/cli to ensure that their versions are safe

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Mar 1, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit 420987d. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@MichaelArestad MichaelArestad added maintenance User-facing maintenance tasks dependencies and removed maintenance User-facing maintenance tasks labels Mar 7, 2022
@shilman shilman merged commit d18ce22 into storybookjs:next Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants