Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change imports of types to be prefixed #17627

Merged
merged 2 commits into from
Mar 8, 2022
Merged

Conversation

ndelangen
Copy link
Member

What I did

I changes most imports of types and interfaces to be imported with the type prefix.

This fixes:

  • eslint warnings
  • makes babel transform faster, because some files will not need to be evaluated
  • it's clear which imports will make an impact at runtime

@nx-cloud
Copy link

nx-cloud bot commented Mar 3, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit 40b7410. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@ndelangen ndelangen self-assigned this Mar 3, 2022
@ndelangen ndelangen added the maintenance User-facing maintenance tasks label Mar 3, 2022
@ndelangen ndelangen force-pushed the tech/cleanup-typed-imports branch from ffc1c1b to 45b3955 Compare March 3, 2022 21:46
@yannbf
Copy link
Member

yannbf commented Mar 7, 2022

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we just merge this directly into next?

@ndelangen ndelangen changed the base branch from tech/builder-cleanup-continued to next March 8, 2022 13:07
@ndelangen ndelangen force-pushed the tech/cleanup-typed-imports branch from 45b3955 to 89830ad Compare March 8, 2022 13:17
@ndelangen
Copy link
Member Author

cleanup of the PR and targetted next @shilman 🙏

Co-authored-by: Yann Braga <yannbf@gmail.com>
@ndelangen ndelangen merged commit c806e2b into next Mar 8, 2022
@ndelangen ndelangen deleted the tech/cleanup-typed-imports branch March 8, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants