-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change imports of types to be prefixed #17627
Conversation
☁️ Nx Cloud ReportCI ran the following commands for commit 40b7410. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
ffc1c1b
to
45b3955
Compare
Would be nice to use this eslint rule (in another PR maybe?): https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/consistent-type-imports.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can we just merge this directly into next
?
45b3955
to
89830ad
Compare
cleanup of the PR and targetted |
Co-authored-by: Yann Braga <yannbf@gmail.com>
What I did
I changes most imports of types and interfaces to be imported with the
type
prefix.This fixes: