-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon-docs: DocsPage story order should match the index #17669
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f19c992. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one! LGTM 💯
…rror-index Addon-docs: DocsPage story order should match the index
Still seeing this issue after updated to the latest. Example |
@himerus I'm a little confused -- it looks like the order in the linked build is the same as the order in the story file: |
@tmeasday Sorry for the confusion or lack of clarification.
My apologies if this is unrelated, or two separate issues based on the code that controls each. |
Well, heck. Now that I re-post that issue, it appears that our "production" Storybook instance is properly updated, and now they DO in fact appear in order. Please disregard my nonsense. Thank for getting this resolved! It has been an annoyance for quite some time on our builds!! |
No worries @himerus I have to say you had me really confused again for a second there! But I am glad the issue is fixed in either case. I guess you were previously running into this bug and now it is fixed so the end result is a good one. |
Issue: #17611
What I did
Ensure
store.componentStoriesFromCSFFile()
returns stories in the same order as the indexHow to test