Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs: DocsPage story order should match the index #17669

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Mar 9, 2022

Issue: #17611

What I did

Ensure store.componentStoriesFromCSFFile() returns stories in the same order as the index

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

@tmeasday tmeasday requested a review from shilman March 9, 2022 06:06
@nx-cloud
Copy link

nx-cloud bot commented Mar 9, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f19c992. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@tmeasday tmeasday changed the title 17611 docs order should mirror index Docs order should be the same as the index Mar 9, 2022
@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Mar 9, 2022
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! LGTM 💯

@shilman shilman changed the title Docs order should be the same as the index Addon-docs: DocsPage story order should match the index Mar 9, 2022
@shilman shilman merged commit 2675de9 into next Mar 9, 2022
@shilman shilman deleted the 17611-docs-order-should-mirror-index branch March 9, 2022 07:26
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 1, 2022
shilman added a commit that referenced this pull request Apr 1, 2022
…rror-index

Addon-docs: DocsPage story order should match the index
@himerus
Copy link

himerus commented Apr 1, 2022

@tmeasday
Copy link
Member Author

tmeasday commented Apr 2, 2022

@himerus I'm a little confused -- it looks like the order in the linked build is the same as the order in the story file:

image

@himerus
Copy link

himerus commented Apr 2, 2022

@tmeasday Sorry for the confusion or lack of clarification.

  • Yes, the sidebar ordering of the Stories matches the order in the Story file.
  • However, the actual Docs PAGE content is what is out of order in that example page.
    • Note the Information Story is down near the middle of the page, and the Error Story appears first (alphabetical).

My apologies if this is unrelated, or two separate issues based on the code that controls each.

@himerus
Copy link

himerus commented Apr 2, 2022

Well, heck. Now that I re-post that issue, it appears that our "production" Storybook instance is properly updated, and now they DO in fact appear in order.

Please disregard my nonsense.

Thank for getting this resolved! It has been an annoyance for quite some time on our builds!!

@tmeasday
Copy link
Member Author

tmeasday commented Apr 3, 2022

No worries @himerus I have to say you had me really confused again for a second there! But I am glad the issue is fixed in either case. I guess you were previously running into this bug and now it is fixed so the end result is a good one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug core patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants