-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon-docs: Refactor docs support into individual framework packages #17695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI ran the following commands for commit a84f75a. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
shilman
changed the title
Addon-docs: Refactor common libraries into docs-utils
Addon-docs: Refactor docs support into individual framework packages
Mar 12, 2022
yannbf
reviewed
Mar 13, 2022
shilman
commented
Mar 13, 2022
tmeasday
reviewed
Mar 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #16210
What I did
@storybook/docs-tools
to contain common functionsangular
,ember
,html
,react
,svelte
,vue
,vue
,web-components
addon-docs
complex preset systemIn the telescoping PR #17697
What to review
docs-tools
make sense?preset-framework-docs
, which in turn calls intodocs-tools
make sense? Does this bloat the framework packages in some way that I'm missing, other than what's handled in Addon-docs: Auto-disable docs presets if docs/controls unused #17697?How to test
I tested this using Storybook test-runner, doing visual snapshot tests against the docs pages in both
next
and this branch.You can see the feature/instructions here: storybookjs/test-runner#79