-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] New documentation site #1773
Conversation
Great work! As far as I remember, you’ve deployed this to some custom domain. Can you bring it in? |
"next/babel", | ||
["env", { | ||
"targets": { | ||
"chrome": 52 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the docsite supposed to work in a wider range of browsers?
Is there a chance that some of those components would be useful as part of |
Codecov Report
@@ Coverage Diff @@
## master #1773 +/- ##
==========================================
+ Coverage 35.74% 92.5% +56.75%
==========================================
Files 472 6 -466
Lines 10134 40 -10094
Branches 1196 2 -1194
==========================================
- Hits 3622 37 -3585
+ Misses 5784 2 -5782
+ Partials 728 1 -727 Continue to review full report at Codecov.
|
# Conflicts: # .eslintignore # yarn.lock
# Conflicts: # lib/cli/bin/generate.js
IMPROVE rendering of button FIX required key prop warning
# Conflicts: # addons/info/README.md # examples/cra-kitchen-sink/src/stories/__snapshots__/index.stories.storyshot # examples/cra-kitchen-sink/src/stories/index.stories.js # package.json # yarn.lock
# Conflicts: # yarn.lock
# Conflicts: # yarn.lock
…es page from manual-setup
…OVE documentation
# Conflicts: # .circleci/config.yml # addons/background/README.md # addons/info/README.md # addons/links/README.md # addons/notes/README.md # addons/storyshots/README.md # lib/components/src/index.js # package.json # yarn.lock
@ndelangen is this going to be merged or are the changes stale? |
@gabrielcsapo thanks for the interest. @domyen is currently figuring out a improved design for this. Likely a lot of this code is salvageable. It will need some upgrades for sure. For not this is stale until we get the new design doc. |
Issue: -documentation system is limited and hard to maintain-
What I did
I build a new documentation site built with next.js
Goals
How to test
It's on netlify