Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD Mailmap #1783

Merged
merged 1 commit into from
Sep 1, 2017
Merged

ADD Mailmap #1783

merged 1 commit into from
Sep 1, 2017

Conversation

ndelangen
Copy link
Member

Issue: -some users have used multiple accounts to commit-

What I did

I added a mailmap so git log shows the same user, see:
https://stacktoheap.com/blog/2013/01/06/using-mailmap-to-fix-authors-list-in-git/

How to test

  • Eat pasta
  • Eat Pizza
  • Compare which one tastes better
  • Post on slack you have tried both, and share which one you liked best
  • Go outside
  • Live a happy life knowing your git log now shows the correct usernames and email-addresses

Also stop switching between email-addresses @shilman.


Custom data about users can be added as a comment in preparation for docs-v2 using this file to read contributors extra detail (opt-in)

@ndelangen ndelangen self-assigned this Sep 1, 2017
@ndelangen ndelangen added the cleanup Minor cleanup style change that won't show up in release changelog label Sep 1, 2017
@ndelangen ndelangen requested a review from a team September 1, 2017 13:12
@codecov
Copy link

codecov bot commented Sep 1, 2017

Codecov Report

Merging #1783 into release/3.3 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/3.3    #1783   +/-   ##
============================================
  Coverage        23.13%   23.13%           
============================================
  Files              253      253           
  Lines             5745     5745           
  Branches           681      694   +13     
============================================
  Hits              1329     1329           
+ Misses            3941     3912   -29     
- Partials           475      504   +29
Impacted Files Coverage Δ
...es__/update-addon-info/update-addon-info.output.js 0% <0%> (ø) ⬆️
lib/codemod/src/transforms/update-addon-info.js 51.16% <0%> (ø) ⬆️
addons/events/src/components/Event.js 0% <0%> (ø) ⬆️
addons/knobs/src/KnobStore.js 6.81% <0%> (ø) ⬆️
lib/ui/src/modules/ui/libs/filters.js 47.36% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/layout.js 12.5% <0%> (ø) ⬆️
...codemod/src/transforms/update-organisation-name.js 40.62% <0%> (ø) ⬆️
addons/knobs/src/components/types/Boolean.js 11.62% <0%> (ø) ⬆️
app/react/src/client/preview/error_display.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Object.js 5.81% <0%> (ø) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 184dae3...f01bf8c. Read the comment docs.

@Hypnosphi Hypnosphi merged commit 6e57332 into release/3.3 Sep 1, 2017
@Hypnosphi Hypnosphi deleted the mailmap branch September 1, 2017 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Minor cleanup style change that won't show up in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants