-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React: Update react and react-dom peerDeps for React18 #17853
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 815fc20. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
e2e for vue is spitting some errors 🤔
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@souppower thanks so much for doing this. the vue3 errors are unrelated and are due to some changes upstream in vue3 that we're looking into separately. i'm going to merge and release! 🚀
|
Issue: #17831
What I did
Added react and react-dom v18 to peer deps
How to test
If your answer is yes to any of these, please make sure to include it in your PR.