Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React: Update react and react-dom peerDeps for React18 #17853

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

souppower
Copy link
Contributor

@souppower souppower commented Apr 1, 2022

Issue: #17831

What I did

Added react and react-dom v18 to peer deps

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Apr 1, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 815fc20. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@souppower
Copy link
Contributor Author

e2e for vue is spitting some errors 🤔

👷 Building Storybook
yarn build-storybook --quiet
info @storybook/vue3 v6.5.0-alpha.53
info 
info => Cleaning outputDir: /tmp/storybook-e2e-testing/vue3/storybook-static
info => Loading presets
info => Compiling preview..
info Addon-docs: using MDX1
info => Using implicit CSS loaders
info => Using default Webpack4 setup
ERR! TypeError: Cannot read property 'NormalModule' of undefined
ERR!     at VueLoaderPlugin.apply (/tmp/storybook-e2e-testing/vue3/node_modules/@storybook/vue3/node_modules/vue-loader/dist/pluginWebpack5.js:44:47)
ERR!     at webpack (/tmp/storybook-e2e-testing/vue3/node_modules/webpack/lib/webpack.js:51:13)
ERR!     at Object.build (/tmp/storybook-e2e-testing/vue3/node_modules/@storybook/builder-webpack4/dist/cjs/index.js:175:18)
ERR!     at async Promise.all (index 1)
ERR!     at async buildStaticStandalone (/tmp/storybook-e2e-testing/vue3/node_modules/@storybook/core-server/dist/cjs/build-static.js:181:28)
ERR!     at async buildStatic (/tmp/storybook-e2e-testing/vue3/node_modules/@storybook/core-server/dist/cjs/build-static.js:201:5)

@shilman shilman marked this pull request as ready for review April 1, 2022 12:37
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@souppower thanks so much for doing this. the vue3 errors are unrelated and are due to some changes upstream in vue3 that we're looking into separately. i'm going to merge and release! 🚀

@shilman shilman changed the title Update react and react-dom peerDeps React: Update react and react-dom peerDeps for React18 Apr 1, 2022
@shilman shilman self-assigned this Apr 1, 2022
@shilman shilman merged commit fe73e6a into storybookjs:next Apr 1, 2022
@souppower souppower deleted the react18 branch April 1, 2022 12:40
@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Apr 1, 2022
@cameron-martin
Copy link

react-test-renderer should also be updated to v18, because the v17 version of it has a peer dependency on react v17.

@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch react
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants