Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint config: consistent use of levels #1789

Merged
merged 1 commit into from
Sep 3, 2017

Conversation

aretecode
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 3, 2017

Codecov Report

Merging #1789 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1789   +/-   ##
=======================================
  Coverage   21.14%   21.14%           
=======================================
  Files         252      252           
  Lines        5693     5693           
  Branches      683      678    -5     
=======================================
  Hits         1204     1204           
- Misses       3961     3975   +14     
+ Partials      528      514   -14
Impacted Files Coverage Δ
lib/ui/src/modules/api/actions/api.js 50.47% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/menu_item.js 19.14% <0%> (ø) ⬆️
lib/codemod/src/transforms/update-addon-info.js 51.16% <0%> (ø) ⬆️
lib/ui/src/libs/key_events.js 23.25% <0%> (ø) ⬆️
app/react-native/src/preview/story_kind.js 0% <0%> (ø) ⬆️
addons/info/src/components/markdown/code.js 24.13% <0%> (ø) ⬆️
addons/knobs/src/KnobStore.js 6.81% <0%> (ø) ⬆️
addons/knobs/src/components/types/Color.js 8% <0%> (ø) ⬆️
addons/knobs/src/components/PropForm.js 8.51% <0%> (ø) ⬆️
addons/knobs/src/components/types/Boolean.js 11.62% <0%> (ø) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4b650e...f712315. Read the comment docs.

Copy link
Member

@igor-dv igor-dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks =)

@Hypnosphi
Copy link
Member

Nice catch!

@Hypnosphi Hypnosphi merged commit bcb232b into storybookjs:master Sep 3, 2017
@Hypnosphi Hypnosphi added the maintenance User-facing maintenance tasks label Sep 3, 2017
@ndelangen ndelangen added cleanup Minor cleanup style change that won't show up in release changelog and removed maintenance User-facing maintenance tasks labels Sep 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Minor cleanup style change that won't show up in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants