Yarn workspaces #1810

Hypnosphi · 2017-09-06T22:05:44Z

Issue: when running yarn in root packages, all the locks for non-root packages are cleared and then recreated with lerna bootstrap. See Hypnosphi#85 (comment)

How to test

Upgrade yarn to latest version
```
brew upgrade yarn
```
In a new terminal session, go to storybook directory and run usual commands (bootstrap, test, etc.)

# Conflicts: # yarn.lock

codecov · 2017-09-06T22:34:11Z

Codecov Report

Merging #1810 into release/3.3 will decrease coverage by 0.01%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           release/3.3    #1810      +/-   ##
===============================================
- Coverage        23.34%   23.32%   -0.02%     
===============================================
  Files              277      281       +4     
  Lines             6041     6045       +4     
  Branches           703      708       +5     
===============================================
  Hits              1410     1410              
+ Misses            4136     4126      -10     
- Partials           495      509      +14

Impacted Files	Coverage Δ
app/react/bin/index.js	`0% <ø> (ø)`
app/vue/src/server/build.js	`0% <ø> (ø)`	⬆️
app/vue/bin/index.js	`0% <ø> (ø)`
app/vue/bin/build.js	`0% <ø> (ø)`
app/react/bin/build.js	`0% <ø> (ø)`
app/react/src/server/index.js	`0% <ø> (ø)`	⬆️
app/react/src/server/build.js	`0% <ø> (ø)`	⬆️
app/vue/src/server/index.js	`0% <ø> (ø)`	⬆️
app/react/src/server/utils.js	`0% <0%> (-53.58%)`	⬇️
addons/info/src/components/types/PropertyLabel.js	`21.05% <0%> (ø)`	⬆️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9c0e84...bd31e8b. Read the comment docs.

Hypnosphi · 2017-09-06T23:10:15Z

package.json

  "scripts": {
    "bootstrap": "./scripts/bootstrap.js",
-    "bootstrap:core": "lerna bootstrap --concurrency 1 --npm-client=\"yarn\" --hoist && node ./scripts/hoist-internals.js",
-    "bootstrap:docs": "cd docs && yarn install",
+    "bootstrap:core": "yarn install && lerna run prepublish && node ./scripts/hoist-internals.js",


Unfortunately, at the moment yarn doesn't run lifecycle hooks when bootstrapping workspaces: yarnpkg/yarn#3911
That's why we need lerna run prepublish here

Hypnosphi · 2017-09-06T23:11:27Z

package.json

  "scripts": {
    "bootstrap": "./scripts/bootstrap.js",
-    "bootstrap:core": "lerna bootstrap --concurrency 1 --npm-client=\"yarn\" --hoist && node ./scripts/hoist-internals.js",
-    "bootstrap:docs": "cd docs && yarn install",
+    "bootstrap:core": "yarn install && lerna run prepublish && node ./scripts/hoist-internals.js",


We can probably now remove yarn install step from yarn bootstrap --reset task, as it runs anyway as part of yarn bootstrap --core

Hypnosphi · 2017-09-06T23:12:34Z

package.json

@@ -80,7 +88,8 @@
    "symlink-dir": "^1.1.0"
  },
  "engines": {
-    "node": "node"
+    "node": "^8.0.0",


This just states the limitation we have de facto

Hypnosphi · 2017-09-06T23:13:45Z

package.json

        "git add"
      ],
      "*.json": [
-        "npm run lint:js -- --fix",
+        "yarn lint:js --fix",
        "git add"
      ],
      "*.md": [


Unfortunately when I try to use yarn for *.md tasks, yarn precommit hangs

Hypnosphi · 2017-09-06T23:23:23Z

scripts/hoist-internals.js

@@ -15,7 +15,7 @@ log.addLevel('success', 3001, { fg: 'green', bold: true });
 log.info(prefix, 'Hoisting internal packages');

 const getLernaPackages = () =>
-  fse.readJson(path.join(__dirname, '..', 'lerna.json')).then(json => json.packages);
+  fse.readJson(path.join(__dirname, '..', 'package.json')).then(json => json.workspaces);


I've noticed that this script always yields Hoisted 0 packages. So either something is broken, or yarn does what's needed. @ndelangen can you please check?

I think yarn workspaces already hoists everything?

Looks like that, I just want to be sure about this

This entire script can be removed if this PR comes thru

Hypnosphi · 2017-09-06T23:24:09Z

app/vue/package.json

-    "storybook-server": "./dist/server/index.js"
+    "build-storybook": "./bin/build.js",
+    "start-storybook": "bin/index.js",
+    "storybook-server": "bin/index.js"


This change is needed because yarn needs some files to link as binaries, see https://github.com/storybooks/storybook/pull/1810/files#r137413061

…now part of bootstrap:core # Conflicts: # .circleci/config.yml

shilman · 2017-09-06T23:45:10Z

lerna.json

    "publish": {
      "ignore": [
        "cra-kitchen-sink",
-        "crna-kitchen-sink",


@Hypnosphi we don't need these because ... "private: true" in package.json?

Because of this: https://github.com/storybooks/storybook/blob/75b0076edb15700f234d2bc1d5b3007f73095cf1/package.json#L9-L15

shilman · 2017-09-06T23:45:53Z

lerna.json

      ]
    }
  },
-  "packages": [


@Hypnosphi why don't we need this anymore?

https://github.com/lerna/lerna#--use-workspaces

If --use-workspaces is true then packages will be overridden by the value from package.json/workspaces.

shilman · 2017-09-06T23:48:24Z

@Hypnosphi Awesome!! I'm excited to learn about workspaces. I tried them out on another project and reverted because it didn't seem to do what I wanted, but I'm eager to learn the right way on storybook 😸

Hypnosphi · 2017-09-07T22:29:20Z

.circleci/config.yml

-          command: |
-            node --version
-            npm --version
-            yarn --version


yarn version won't print the correct version anymore, This script isn't providing value really.

Maybe comment it instead? To reenable once docker image gets updated

Meh, it's really not useful the info is in the logs anyway.

Hypnosphi · 2017-09-07T22:31:48Z

scripts/bootstrap.js

@@ -71,6 +77,9 @@ const tasks = {
    defaultValue: true,
    option: '--core',
    command: () => {
+      log.info(prefix, 'prepublish');
+      spawn('lerna run prepublish -- --silent');


this won't work without global lerna installed

and without some package deps like babel as well

isn't lerna a local dependency?

Hmm, yes, didn't know you can run local deps with spawn. The problem is that we effectively yarn install two times in this setup. Why not just once?

Ok, you can't run bootstrap script without root dependencies anyway

…gether

…k` runs `prepublish` anyway

…`npm pack` runs `prepublish` anyway" This reverts commit f3046d5.

ndelangen

WORKS ON MY MACHINE

# Conflicts: # package.json

Hypnosphi · 2017-09-29T19:33:51Z

.circleci/config.yml

      - run:
          name: "Bootstrapping"
          command: |
-            yarn bootstrap -- --all
+            yarn bootstrap --core --docs --reactnative --reactnativeapp


What was wrong with --all?
Oh I see, the reset step would remove the cache

Hypnosphi added 2 commits September 7, 2017 00:55

Introduce yarn workspaces

4d10a55

Add export PATH

adb20c6

Hypnosphi changed the base branch from master to release/3.3 September 6, 2017 22:06

Hypnosphi added ci: do not merge maintenance User-facing maintenance tasks labels Sep 6, 2017

Hypnosphi added 7 commits September 7, 2017 01:07

Merge remote-tracking branch 'upstream/release/3.3' into yarn-workspaces

dc0bd90

# Conflicts: # yarn.lock

update lockfile

2486947

add BASH_ENV

b4d9ee0

add BASH_ENV

d22f209

CI: Temporarily disable all steps but lint

cd7472a

Enable all the steps back, extract environment into defaults

51363c2

Use --cwd flag for bootstrapping docs

78a42a8

Hypnosphi added 2 commits September 7, 2017 01:58

Use yarn scripts where possible, omitting extra -- because now we can

2308e98

Update documentation

fee27b5

Hypnosphi changed the title ~~[WIP] Yarn workspaces~~ Yarn workspaces Sep 6, 2017

Fix lerna.json

6d37521

Hypnosphi commented Sep 6, 2017

View reviewed changes

Hypnosphi and others added 2 commits September 7, 2017 02:25

Merge branch 'release/3.3' into yarn-workspaces

d846b0c

CI: Remove "Install root dependencies" phase where possible, as it's …

5d8e07e

…now part of bootstrap:core # Conflicts: # .circleci/config.yml

Hypnosphi mentioned this pull request Sep 6, 2017

Run bootstrap before linting on CI #1698

Closed

Merge branch 'release/3.3' into yarn-workspaces

75b0076

shilman reviewed Sep 6, 2017

View reviewed changes

Hypnosphi and others added 2 commits September 7, 2017 02:58

CI: use yarn nightly in docs task

181878d

Merge branch 'release/3.3' into yarn-workspaces

cc9ab25

Hypnosphi removed the ci: do not merge label Sep 7, 2017

IMPROVE yarn workspaces setup

5382fcb

Hypnosphi commented Sep 7, 2017

View reviewed changes

ndelangen and others added 8 commits September 8, 2017 00:45

CHANGE package.json.engines

8df6f4d

CI: use latest yarn instead of nightly. Cache all the dependencies to…

fe9ee4e

…gether

CI: bring back install phase, as it's needed for bootstrap script

38011e8

bootstrap: use yarn install directly

f343861

CI: bootstrap --core isn't needed for react-native examples, `npm pac…

f3046d5

…k` runs `prepublish` anyway

Replace the deprecated prepublish script with prepare

824bbd6

Revert "CI: bootstrap --core isn't needed for react-native examples, …

11298bf

…`npm pack` runs `prepublish` anyway" This reverts commit f3046d5.

Merge branch 'release/3.3' into yarn-workspaces

088c5f8

ndelangen approved these changes Sep 8, 2017

View reviewed changes

ndelangen mentioned this pull request Sep 8, 2017

Use dependencies.io Lerna support & disable issue creation #1803

Closed

Hypnosphi added this to the v3.3.0 milestone Sep 8, 2017

Merge remote-tracking branch 'upstream/release/3.3' into yarn-workspaces

bd31e8b

# Conflicts: # package.json

Hypnosphi merged commit 8052c61 into release/3.3 Sep 8, 2017

Hypnosphi deleted the yarn-workspaces branch September 8, 2017 23:42

Hypnosphi commented Sep 29, 2017

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Yarn workspaces #1810

Yarn workspaces #1810

Hypnosphi commented Sep 6, 2017 •

edited

Loading

codecov bot commented Sep 6, 2017 •

edited

Loading

Hypnosphi Sep 6, 2017

Hypnosphi Sep 6, 2017

Hypnosphi Sep 6, 2017 •

edited

Loading

Hypnosphi Sep 6, 2017

ndelangen Sep 7, 2017

Hypnosphi Sep 6, 2017

shilman Sep 6, 2017

Hypnosphi Sep 6, 2017 •

edited

Loading

ndelangen Sep 8, 2017

Hypnosphi Sep 6, 2017 •

edited

Loading

shilman Sep 6, 2017

Hypnosphi Sep 6, 2017 •

edited

Loading

shilman Sep 6, 2017

Hypnosphi Sep 6, 2017

shilman commented Sep 6, 2017

Hypnosphi Sep 7, 2017

ndelangen Sep 7, 2017

Hypnosphi Sep 7, 2017

ndelangen Sep 8, 2017

Hypnosphi Sep 7, 2017

Hypnosphi Sep 7, 2017

ndelangen Sep 7, 2017

Hypnosphi Sep 7, 2017 •

edited

Loading

Hypnosphi Sep 8, 2017

ndelangen left a comment

Hypnosphi Sep 29, 2017 •

edited

Loading

Yarn workspaces #1810

Yarn workspaces #1810

Conversation

Hypnosphi commented Sep 6, 2017 • edited Loading

How to test

codecov bot commented Sep 6, 2017 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Hypnosphi Sep 6, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Hypnosphi Sep 6, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Hypnosphi Sep 6, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Hypnosphi Sep 6, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shilman commented Sep 6, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Hypnosphi Sep 7, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ndelangen left a comment

Choose a reason for hiding this comment

Hypnosphi Sep 29, 2017 • edited Loading

Choose a reason for hiding this comment

Hypnosphi commented Sep 6, 2017 •

edited

Loading

codecov bot commented Sep 6, 2017 •

edited

Loading

Hypnosphi Sep 6, 2017 •

edited

Loading

Hypnosphi Sep 6, 2017 •

edited

Loading

Hypnosphi Sep 6, 2017 •

edited

Loading

Hypnosphi Sep 6, 2017 •

edited

Loading

Hypnosphi Sep 7, 2017 •

edited

Loading

Hypnosphi Sep 29, 2017 •

edited

Loading