UI: Externalize react-syntax-highlighter from components
#18127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 43d873e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
shilman
changed the title
shilman
changed the title
react-syntax-highlighter from components
|
Heya, I got here after I encountered issues with Volar and @types/react-syntax-highlighter not playing well together. Are there any intentions in the future towards putting the types back in devDependencies? |
|
Yes, in 7.0 it will all be encapsulated fully! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #18090
What I did
Externalize react-syntax-highlighter
I think in the future we'll have to migrate away from react-syntax-highlighter because of the bug described in the issue.
Possibly we could migrate to call Prism directly, or find some other alternative.