Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add missing NPM script section to Vue guide #1824

Merged
merged 1 commit into from
Sep 8, 2017
Merged

Docs: Add missing NPM script section to Vue guide #1824

merged 1 commit into from
Sep 8, 2017

Conversation

JanCVanB
Copy link
Contributor

@JanCVanB JanCVanB commented Sep 8, 2017

It seems that this necessary setup step didn't get copy-pasted over from the React guide (probably because it isn't a standalone section in the React guide).

It seems that this necessary setup step didn't get copy-pasted over from the React guide (probably because it isn't a standalone section in the React guide).
@codecov
Copy link

codecov bot commented Sep 8, 2017

Codecov Report

Merging #1824 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1824   +/-   ##
=======================================
  Coverage   21.32%   21.32%           
=======================================
  Files         257      257           
  Lines        5739     5739           
  Branches      687      689    +2     
=======================================
  Hits         1224     1224           
+ Misses       3995     3986    -9     
- Partials      520      529    +9
Impacted Files Coverage Δ
app/vue/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/vue/src/server/babel_config.js 0% <0%> (-77.42%) ⬇️
addons/knobs/src/components/PropForm.js 8.51% <0%> (ø) ⬆️
addons/info/src/components/markdown/code.js 24.13% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/layout/dimensions.js 15.62% <0%> (ø) ⬆️
lib/ui/src/modules/ui/libs/hierarchy.js 48.8% <0%> (ø) ⬆️
...res__/update-addon-info/update-addon-info.input.js 0% <0%> (ø) ⬆️
addons/info/src/components/Props.js 36.36% <0%> (ø) ⬆️
...codemod/src/transforms/update-organisation-name.js 40.62% <0%> (ø) ⬆️
app/react/src/client/preview/error_display.js 0% <0%> (ø) ⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01ead66...cc74b32. Read the comment docs.

@ndelangen ndelangen merged commit 90eb0ee into storybookjs:master Sep 8, 2017
@ndelangen
Copy link
Member

Thank you very much @JanCVanB ! I will deploy a new docs version now!

@ndelangen
Copy link
Member

@JanCVanB
Copy link
Contributor Author

JanCVanB commented Sep 8, 2017

Thanks @ndelangen!

@JanCVanB JanCVanB deleted the patch-1 branch October 16, 2017 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants