-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README: mention that addon-links needs to be registered manually #1835
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1835 +/- ##
=======================================
Coverage 21.32% 21.32%
=======================================
Files 257 257
Lines 5739 5739
Branches 686 678 -8
=======================================
Hits 1224 1224
+ Misses 4020 3996 -24
- Partials 495 519 +24
Continue to review full report at Codecov.
|
Thanks @crtvhd!
Would you like to fix it as well, since it should be installed now? |
I changed it @usulpro ✅ Merge when ready |
Why not as a devDependency? 😕 |
yeah that would be even better |
Well @ndelangen was faster :) Thanks! |
Issue:
What I did
Update README.md by mentioning that
addon-links
needs to be manually registered. I just ran into this and since the README didn't mention anything it cost me some time to figure out why I couldn't make it work.How to test
N.A.
Is this testable with jest or storyshots?
N.A.
Does this need a new example in the kitchen sink apps?
N.A.
Does this need an update to the documentation?
N.A.
If your answer is yes to any of these, please make sure to include it in your PR.