Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README: mention that addon-links needs to be registered manually #1835

Merged
merged 3 commits into from
Sep 12, 2017

Conversation

mrtnpro
Copy link
Contributor

@mrtnpro mrtnpro commented Sep 12, 2017

Issue:

What I did

Update README.md by mentioning that addon-links needs to be manually registered. I just ran into this and since the README didn't mention anything it cost me some time to figure out why I couldn't make it work.

How to test

N.A.

Is this testable with jest or storyshots?
N.A.
Does this need a new example in the kitchen sink apps?
N.A.
Does this need an update to the documentation?
N.A.
If your answer is yes to any of these, please make sure to include it in your PR.

@mrtnpro mrtnpro changed the title Update README.md: add hint that addon needs to be registered Update README: mention that addon-links needs to be registered manually Sep 12, 2017
@codecov
Copy link

codecov bot commented Sep 12, 2017

Codecov Report

Merging #1835 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1835   +/-   ##
=======================================
  Coverage   21.32%   21.32%           
=======================================
  Files         257      257           
  Lines        5739     5739           
  Branches      686      678    -8     
=======================================
  Hits         1224     1224           
+ Misses       4020     3996   -24     
- Partials      495      519   +24
Impacted Files Coverage Δ
lib/ui/src/modules/ui/containers/layout.js 12.5% <0%> (ø) ⬆️
addons/knobs/src/react/WrapStory.js 12% <0%> (ø) ⬆️
addons/knobs/src/components/PropField.js 10.86% <0%> (ø) ⬆️
addons/knobs/src/components/types/Number.js 8.06% <0%> (ø) ⬆️
addons/events/src/components/Event.js 0% <0%> (ø) ⬆️
addons/info/src/components/markdown/htags.js 30% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_routing.js 28.04% <0%> (ø) ⬆️
lib/ui/src/modules/ui/routes.js 0% <0%> (ø) ⬆️
...react-native/src/manager/components/PreviewHelp.js 0% <0%> (ø) ⬆️
app/react/src/client/preview/error_display.js 0% <0%> (ø) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bdf6c2...242cb8a. Read the comment docs.

@usulpro
Copy link
Member

usulpro commented Sep 12, 2017

Thanks @crtvhd!
Sorry that confused you with this outdated description!

You can use this addon without installing it.

Would you like to fix it as well, since it should be installed now?

@ndelangen
Copy link
Member

I changed it @usulpro

Merge when ready

@Hypnosphi Hypnosphi merged commit 4664bf9 into storybookjs:master Sep 12, 2017
@usulpro
Copy link
Member

usulpro commented Sep 12, 2017

Why not as a devDependency? 😕

@ndelangen
Copy link
Member

yeah that would be even better

@mrtnpro
Copy link
Contributor Author

mrtnpro commented Sep 13, 2017

Would you like to fix it as well, since it should be installed now?

Well @ndelangen was faster :) Thanks!

@mrtnpro mrtnpro deleted the patch-1 branch September 13, 2017 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants