-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webpack5: Don't import a second file while a first one is in flight #18432
Webpack5: Don't import a second file while a first one is in flight #18432
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit ca1a7a5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Codecov Report
@@ Coverage Diff @@
## next #18432 +/- ##
==========================================
- Coverage 32.01% 32.00% -0.01%
==========================================
Files 975 975
Lines 19234 19239 +5
Branches 4033 4036 +3
==========================================
Hits 6158 6158
- Misses 12513 12518 +5
Partials 563 563
Continue to review full report at Codecov.
|
bdd6f61
to
1f02c5c
Compare
Codecov Report
@@ Coverage Diff @@
## future/base #18432 +/- ##
===============================================
- Coverage 30.74% 30.73% -0.01%
===============================================
Files 798 798
Lines 17086 17091 +5
Branches 3528 3531 +3
===============================================
Hits 5253 5253
- Misses 11408 11413 +5
Partials 425 425
Continue to review full report at Codecov.
|
…uence-importing-stories-in-parallel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI build step is failing
…uence-importing-stories-in-parallel
Issue: Lazy compilation can fail if CSF files are imported very quickly, either by navigating or via preloading (#17964)
webpack/webpack#15541
What I did
Introduce a "pipeline" into
import()
when Lazy Compilation is active. The pipeline will stop us from runningimport()
a second time while a firstimport()
is in flight.How to test
Turn on lazy compilation in the
react-ts
example:NOTE
@yannbf this will not help with the test runner bug as it simply "debounces" things on the client side, but in the case of the TR, there are multiple clients, so that cannot happen. A true fix is (maybe?) to do a similar pipelining in on the lazy compilation backend in webpack.