Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactions: Reset instrumenter state on HMR #18516

Merged

Conversation

ghengeveld
Copy link
Member

Issue: #17570

What I did

Reset instrumenter state so we stop debugging on HMR.

How to test

  • Run a story with play function
  • Start debugging
  • Add new interaction to play function (code) and save the file to trigger HMR
  • Verify the interaction panel resets (stop debugging) and the new interaction is displayed and run as normal

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Jun 20, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 565304c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@ghengeveld ghengeveld changed the title Reset instrumenter state on HMR Interactions: Reset instrumenter state on HMR Jun 20, 2022
@ghengeveld ghengeveld requested a review from yannbf June 20, 2022 12:23
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @ghengeveld <3

@shilman shilman merged commit a3348bf into next Jun 21, 2022
@shilman shilman deleted the ghengeveld/sb-167-sb17570-addon-interactions-panel-does branch June 21, 2022 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants