Build: Enable Template.bind({}) TS support in our repo #18540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rve typings in stories now
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 9d55444. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
kylegach
approved these changes
Jun 22, 2022
There was a problem hiding this comment.
Nice!
Looks like there's a few places we can simplify types: https://cs.github.com/?q=Template.bind(%7B%7D)%20repo%3Astorybookjs%2Fstorybook%20language%3ATypeScript&scopeName=storybookjs&scope=org%3Astorybookjs
yannbf
approved these changes
Jun 22, 2022
shilman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so it's better, we can do Template.bind({}) and preserve typings in stories now