Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SETTING_UP_A_DEV_ENVIRONMENT.md for version 3.3.0-alpha.0 #1864

Closed

Conversation

dangreenisrael
Copy link
Member

@dangreenisrael dangreenisrael commented Sep 19, 2017

This is the 3.3 version of this PR: #1856

What I did

I created a walkthrough for setting up a dev environment with a demo project

Why I did it

It took me a while to get my dev environment set up, so I thought I would codify the steps needed to do it.

Notes

This version was tested against @storybook/cli@v3.3.0-alpha.0

@codecov
Copy link

codecov bot commented Sep 19, 2017

Codecov Report

Merging #1864 into release/3.3 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/3.3    #1864   +/-   ##
============================================
  Coverage        22.26%   22.26%           
============================================
  Files              324      324           
  Lines             6337     6337           
  Branches           812      814    +2     
============================================
  Hits              1411     1411           
+ Misses            4309     4306    -3     
- Partials           617      620    +3
Impacted Files Coverage Δ
...codemod/src/transforms/update-organisation-name.js 40.62% <0%> (ø) ⬆️
lib/components/src/highlight_button.js 0% <0%> (ø) ⬆️
addons/viewport/src/components/RotateViewport.js 22.72% <0%> (ø) ⬆️
lib/ui/src/modules/ui/libs/hierarchy.js 50.74% <0%> (ø) ⬆️
addons/storyshots/src/test-bodies.js 19.14% <0%> (ø) ⬆️
addons/knobs/src/KnobStore.js 6.81% <0%> (ø) ⬆️
addons/knobs/src/components/PropForm.js 8.51% <0%> (ø) ⬆️
lib/ui/src/modules/ui/routes.js 0% <0%> (ø) ⬆️
addons/storyshots/src/require_context.js 45.58% <0%> (ø) ⬆️
addons/info/src/components/PropTable.js 22.22% <0%> (ø) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6b2871...89f64e8. Read the comment docs.

@danielduan danielduan added this to the v3.3.0 milestone Sep 19, 2017
@Hypnosphi
Copy link
Member

This file partly duplicates CONTRIBUTING.md. Can we have just one?

@dangreenisrael
Copy link
Member Author

@Hypnosphi I can consolidate them tonight

@dangreenisrael
Copy link
Member Author

@Hypnosphi After going over the 3.3 version of CONTRIBUTING.md in more depth, I think that this is fairly redundant. I originally wrote it after having a hard time with the docs in master, as I didn't know about 3.3. I'm going to close this for now, but if you think there is some value in this I can always re-open it at a later time. Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants