Support DocsPage in v6 store #18763
Merged
Support DocsPage in v6 store #18763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8dbe13c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
tmeasday
force-pushed
the
tom/sb-475-support-storystorev6
branch
2 times, most recently
from
9807793 to
8dbe13c
Compare
shilman
reviewed
Jul 25, 2022
Base automatically changed from
tom/sb-505-info-remains-selected-when-changing
to
next
July 26, 2022 04:16
tmeasday
force-pushed
the
tom/sb-475-support-storystorev6
branch
from
3d9ec15 to
23a2c7c
Compare
shilman
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Telescoping on #18762
Issue: https://linear.app/chromaui/issue/SB-475/support-storystorev6
What I did
Implement DocsPage 2 in SSv6:
SET_STORIESto an index in the managerTo discuss
We didn't yet talk about how story sorting (v6) will work with docs page. For now I just generate a "story like" object to pass to the sort function that'll have an appropriate name + title. There's no easy way to tell it is a docs entry though.
How to test
Our tests in the manager are OK. We don't really have tests for the preview side -- I'm not quite sure how to think about SSv6. Probably as it's not something we focus on, tests are more important--I'll try and add some in an upcoming refactor of this area of the code.
To test in
react-ts, turn offstoryStoreV7and remove the docs 2 stories entries.