-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build addons-actions with ts-up #18775
Conversation
# Conflicts: # code/addons/actions/package.json # code/yarn.lock
@ndelangen I am stuck on this PR. I don't know why the test is failing. I tried to run the cra-essentials app locally with the |
# Conflicts: # code/addons/actions/package.json
There seems to be an issue with this change: |
Looks like my fix didn't do anything to the CI failure. I'm not sure what's causing it. |
# Conflicts: # code/addons/actions/package.json
# Conflicts: # code/addons/actions/package.json
# Conflicts: # code/addons/actions/package.json
I compared: And the after seems to work just as good if not better. I will merge this! |
Issue: #18732
What I did
Followed the instructions from the above issue. Not very sure about the 'preview' setup, please let me know if it needs fixing.
The example was working correctly locally.
How to test
If your answer is yes to any of these, please make sure to include it in your PR.